@ollelauribostrom this now has a conflict unfortunately. There are a couple other PRs that are open that this will likely conflict with so I think it might make sense to work on getting the missing features landed first before we do a refactor like this.

@MylesBorins I see your point, probably a good idea to get some of these PRs merged before this. The conlicts seems easy enough to resolve, but should I hold off on that for a while?

@MylesBorins This should now be up to speed with the latest features in master :)

/gcbrun

eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/9cbbfce/index.html

Sidenote: As of #66 we might want to refactor some of the classes to use hooks instead but that can be addressed later on 🙂

/gcbrun

eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/a829169/index.html

I would like to see sign off from at least one other person before landing this. I'm not familiar enough with react to review

@MylesBorins I see this on latest staging example -

PS - Reviewing this PR

@mbj36 it looks like the build failed, lets find out why.

Step #1: error Building static HTML for pages failed
Step #1: 
Step #1: See our docs page on debugging HTML builds for help https://gatsby.app/debug-html
Step #1: 
Step #1: 39 | render() {
Step #1: 40 | const { data } = this.props;
Step #1: > 41 | const currentPage = location.pathname.split('/').pop();
Step #1: | ^
Step #1: 42 | const { activePage, previousPage, nextPage, navigationSections } = findActive(data.sections.group, currentPage);
Step #1: 43 | if (!activePage) {
Step #1: 44 | // Rendering 404 page as a component here

@MylesBorins Build should pass now if you run again

@MylesBorins Looks like I forgot to destructure location from this.props which may be the cause (fixed now). Weird though because this works for me locally 🤔

/gcbrun

eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/0d2da34/index.html

I also opened up a PR that will have travis run the build to ensure that travis isn't 'green' if the build is broken

@ollelauribostrom Should we keep layout.css inside components folder ?

Also in current .prettierrc, semi is set to false, (your changes has semi true) it might cause confusion among the devs.

Also i get this tslint warning - https://stackoverflow.com/questions/50319251/array-type-using-arrayt-is-forbidden

Seems to have conflicts again @ollelauribostrom

@LaRuaNa @mbj36 Conflicts should now be resolved again and the tslint issues fixed. Holding off on any prettier fixes for now (will change anyways as of #90 etc) 🙂

/gcbrun

eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/fdae987/index.html