This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Remove requests module example from docs#599
Merged
Merged
Conversation
the request module is deprecated. It also doesn't use promises which is the greatest benefit to node.
alexandrtovmach
approved these changes
Apr 25, 2020
alexandrtovmach
left a comment
alexandrtovmach
left a comment
Contributor
There was a problem hiding this comment.
Agree, we shouldn't show deprecated examples! Good catch @MattMartin1919
Contributor
|
/gcbrun |
Contributor
Author
|
Hey @alexandrtovmach, I tried to submit another PR to handle this issue: but it seems to have added it to this request instead. Still getting the hang of git and contributing to open source projects through PRs so let me know how to proceed here! |
Contributor
# undo unrelated changes
git reset a042093
# stash this changes
git stash 'Changes for #232'
# undo to expected changes
git reset --hard b81eacb
# push to origin repo with overriding
git push origin master --force
# creating new branch
git checkout -b patch/232
# apply and remove latest stash
git stash pop
# commit changes related to another issue
git add .
git commit -m "feat: Updated docs to solve #232"
# push to remote repo new branch with changes for issue #232
git push -u patch/232and create a new PR from patch/232 to nodejs.dev:master
|
Contributor
Author
|
Thanks for the help @alexandrtovmach! This PR should be just the "removing requests" change 😄 |
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request module is "deprecated". While still supported, as in accepting PRs, I think it can be removed from the docs without any harm so newcomers can read up on promise based libraries instead. Completely ok if you don't agree! Feel free to reject the PR in that case 😄
Description
I removed the request example from the docs and fixed the wording that specifies Axios is a 3rd party library.