Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Update mention of ZEIT Now in hosting docs#557

Merged
alexandrtovmach merged 6 commits into
nodejs:masterfrom
leo:patch-1
Apr 25, 2020
Merged

Update mention of ZEIT Now in hosting docs#557
alexandrtovmach merged 6 commits into
nodejs:masterfrom
leo:patch-1

Conversation

@leo

@leo leo commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

The old description of ZEIT Now was about running Node.js servers. Now that ZEIT Now is focused on deploying static frontends and serverless APIs, it had to be adjusted.

@Trott

Trott commented Apr 23, 2020

Copy link
Copy Markdown
Member

This page should be removed in my opinion. We shouldn't get into the business of recommending where people should host their apps.

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not describe any product with language like "is the right choice".

@Trott

Trott commented Apr 23, 2020

Copy link
Copy Markdown
Member

We should not describe any product with language like "is the right choice".

Ugh, although I also see we have language like "amazing" elsewhere on the page. 😞

@benhalverson

benhalverson commented Apr 23, 2020

Copy link
Copy Markdown
Member

Also zeit renamed themselves to Vercel.
https://vercel.com/blog/zeit-is-now-vercel

@Trott Trott mentioned this pull request Apr 23, 2020
Comment thread src/documentation/0010-node-hosting/index.md Outdated
Comment thread src/documentation/0010-node-hosting/index.md Outdated
Comment thread src/documentation/0010-node-hosting/index.md Outdated
leo and others added 3 commits April 23, 2020 17:00
Co-Authored-By: Steven <steven@ceriously.com>
Co-Authored-By: Steven <steven@ceriously.com>
Co-Authored-By: Steven <steven@ceriously.com>
@Trott

Trott commented Apr 24, 2020

Copy link
Copy Markdown
Member

/gcbrun

@Trott

Trott commented Apr 24, 2020

Copy link
Copy Markdown
Member

I'm going to remove my objection because the current proposed change is an improvement so let's go ahead and land it. But I have proposed elsewhere that this page be removed, so the change may not stay for too long if that happens.

@alexandrtovmach

Copy link
Copy Markdown
Contributor

/gcbrun

@alexandrtovmach alexandrtovmach merged commit 89a4447 into nodejs:master Apr 25, 2020
@styfle

styfle commented Apr 25, 2020

Copy link
Copy Markdown
Member

It looks like this change is not deployed?

https://nodejs.dev/where-to-host-a-nodejs-app

Perhaps your deployment platform is down?

image

@alexandrtovmach

Copy link
Copy Markdown
Contributor

This file removed from website content, as @Trott said earlier

@styfle

styfle commented Apr 25, 2020

Copy link
Copy Markdown
Member

If the file was removed, why is the page still live?

@nschonni

Copy link
Copy Markdown
Member

There is split branching going on right now that requires manual merges between branches for publishing #587

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants