Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Downloads Page#547

Closed
saulonunesdev wants to merge 5 commits into
nodejs:stagingfrom
saulonunesdev:feat/releases-page
Closed

Downloads Page#547
saulonunesdev wants to merge 5 commits into
nodejs:stagingfrom
saulonunesdev:feat/releases-page

Conversation

@saulonunesdev

@saulonunesdev saulonunesdev commented Apr 11, 2020

Copy link
Copy Markdown

Description

Releases/Download Page #261

NOT READY TO BE MERGED

Related Issues

@benhalverson

Copy link
Copy Markdown
Member

/gcbrun

@alexandrtovmach alexandrtovmach added the enhancement New feature or request label Apr 25, 2020
@MylesBorins

Copy link
Copy Markdown
Contributor

Looks like this is going to need a rebase

@saulonunesdev saulonunesdev self-assigned this May 16, 2020
@saulonunesdev

Copy link
Copy Markdown
Author

/preview

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/547/

@saulonunesdev

Copy link
Copy Markdown
Author

/preview

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/547/

Comment thread src/components/Header/__tests__/__snapshots__/header.test.tsx.snap
@nschonni nschonni marked this pull request as draft May 24, 2020 20:56
@saulonunesdev saulonunesdev changed the title First Draft of Releases Page Downloads Page May 26, 2020
@saulonunesdev

Copy link
Copy Markdown
Author

Hi Everyone, i need some help, where do i get data for those sections bellow.

image

image

figma: https://www.figma.com/file/lOxAGGg5KXb6nwie7zXkz6/NJ---Design-System?node-id=22%3A6086

@benhalverson

Copy link
Copy Markdown
Member

@saulonunesdev I've been referencing this page for the dates.
https://nodejs.org/en/about/releases/

@saulonunesdev

Copy link
Copy Markdown
Author

/preview

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/547/

@benhalverson

benhalverson commented Jul 9, 2020

Copy link
Copy Markdown
Member

/preview

@designMoreWeb

Copy link
Copy Markdown
Contributor

image
Please check this is what I am getting when clicking on the link for the preview

@willin willin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/preview

@github-actions

github-actions Bot commented Jul 9, 2020

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/547/

@benhalverson

Copy link
Copy Markdown
Member

/preview

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/547/

@saulonunesdev saulonunesdev marked this pull request as ready for review August 11, 2020 14:37
@saulonunesdev saulonunesdev mentioned this pull request Aug 12, 2020
jemjam added a commit to jemjam/nodejs.dev that referenced this pull request Sep 7, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.
jemjam added a commit to jemjam/nodejs.dev that referenced this pull request Sep 7, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.

- Add all the Download templates that were green from original PR
- Add to the style tokens
benhalverson pushed a commit that referenced this pull request Sep 9, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.

- Add all the Download templates that were green from original PR
- Add to the style tokens
singhshivanshu pushed a commit to singhshivanshu/nodejs.dev that referenced this pull request Sep 10, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.

- Add all the Download templates that were green from original PR
- Add to the style tokens
benhalverson pushed a commit to singhshivanshu/nodejs.dev that referenced this pull request Oct 11, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.

- Add all the Download templates that were green from original PR
- Add to the style tokens
marcustisater pushed a commit to singhshivanshu/nodejs.dev that referenced this pull request Oct 11, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.

- Add all the Download templates that were green from original PR
- Add to the style tokens
benhalverson pushed a commit that referenced this pull request Oct 11, 2020
A huge acknowledgement to @saulonunesdev for putting together these
templates initially. The PR looked great but ended up with some
additional content that needed to be refactored out. This commit
restores the work he put in to update the Downloads page.

- Add all the Download templates that were green from original PR
- Add to the style tokens
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request wip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants