feat: Social Meta Data#51
Conversation
|
can we also do the twitter cards' tags? |
|
😅 thank you. |
b185f0f to
723ae66
Compare
|
@codeekage I've gone ahead and rebased to fix conflicts and also added a commit to fix a build issue. There is currently still a runtime error, it seems the "Author" tag is relying on information that is not currently available |
MylesBorins
left a comment
There was a problem hiding this comment.
Currently this PR does not run. Feel free to dismiss this review when the issues I mentioned above are fixed.
|
/gcbrun |
|
/gcbrun eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/d9de42a/index.html @codeekage I ran this locally and did not see author info. Where should it be showing up? |
|
It looks like #68 has landed which unfortunately duplicated some of the bits included in this PR. I'm going to go ahead and close this. Thanks for the work @codeekage |
|
@codeekage do you want to open a PR fixing that? |
closing #47