Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

feat: Social Meta Data#51

Closed
codeekage wants to merge 6 commits into
nodejs:masterfrom
codeekage:codeekage-patch
Closed

feat: Social Meta Data#51
codeekage wants to merge 6 commits into
nodejs:masterfrom
codeekage:codeekage-patch

Conversation

@codeekage

Copy link
Copy Markdown
Contributor

closing #47

@maddhruv

Copy link
Copy Markdown

can we also do the twitter cards' tags?

@codeekage

Copy link
Copy Markdown
Contributor Author

😅 thank you.

@MylesBorins

Copy link
Copy Markdown
Contributor

@codeekage I've gone ahead and rebased to fix conflicts and also added a commit to fix a build issue. There is currently still a runtime error, it seems the "Author" tag is relying on information that is not currently available

ReferenceError: author is not defined
render
src/components/layout.tsx:40
  37 | { name: 'title', content: title },
  38 | { name:"twitter:card", content:"summary"},
  39 | { name:"twitter:site", content:"@nodejs"},
> 40 | { name:"twitter:creator", content:`@${author}`},
  41 | { property: 'og:title', content: title },
  42 | { property: 'og:image', content: image },
  43 | { property: 'og:image:type', content: 'image/png' },

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this PR does not run. Feel free to dismiss this review when the issues I mentioned above are fixed.

@MylesBorins MylesBorins added the enhancement New feature or request label Feb 19, 2019
@MylesBorins

Copy link
Copy Markdown
Contributor

/gcbrun

@codeekage codeekage dismissed MylesBorins’s stale review February 20, 2019 18:39

fixed: author not defined

@MylesBorins

Copy link
Copy Markdown
Contributor

/gcbrun

eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/d9de42a/index.html

@codeekage I ran this locally and did not see author info. Where should it be showing up?

@MylesBorins

Copy link
Copy Markdown
Contributor

It looks like #68 has landed which unfortunately duplicated some of the bits included in this PR. I'm going to go ahead and close this. Thanks for the work @codeekage

@codeekage

Copy link
Copy Markdown
Contributor Author

{ name:"twitter:creator", content:@${author}}, this reference the author of the article, rather than the generic nodejs. More of giving credits to the original author. #68 uses a generic @nodejs still cool.

@MylesBorins

Copy link
Copy Markdown
Contributor

@codeekage do you want to open a PR fixing that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants