Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

build: Yarn -> NPM#461

Merged
nschonni merged 1 commit into
nodejs:masterfrom
nschonni:yarn-to-npm
Mar 27, 2020
Merged

build: Yarn -> NPM#461
nschonni merged 1 commit into
nodejs:masterfrom
nschonni:yarn-to-npm

Conversation

@nschonni

@nschonni nschonni commented Mar 24, 2020

Copy link
Copy Markdown
Member

Description

Related to #321 as mentioned Yarn isn't part of the shipped NodeJS distributions, so probably better to stick to NPM for developing the site.

Related Issues

@nschonni

Copy link
Copy Markdown
Member Author

Think i'll try and try a tool that translates the yarn.lock -> package-lock.json file. I think most of the current failures are related to bumping the packages so I'd like to try and filter out those issues hand handle them separately with the dependabot PRs

@nschonni

Copy link
Copy Markdown
Member Author

Used https://github.com/imsnif/synp to sync the file instead of deleting the yarn.lock and re-running npm install to regenerate a new package-lock.json. This avoids the failures from the dependency bumps

@nschonni

Copy link
Copy Markdown
Member Author

/gcbrun

@nschonni

Copy link
Copy Markdown
Member Author

I can't see what the GCB run failure is. Can someone with permissions let me know what the error is?

@benhalverson

Copy link
Copy Markdown
Member

ping @MylesBorins can you help with this?

@MylesBorins

Copy link
Copy Markdown
Contributor
 nodejs-website@0.3.0 build-ci /workspace
> gatsby build --prefix-paths

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'lodash.throttle'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/workspace/node_modules/gatsby-cli/node_modules/ink/build/instance.js:10:38)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! nodejs-website@0.3.0 build-ci: `gatsby build --prefix-paths`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the nodejs-website@0.3.0 build-ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /builder/home/.npm/_logs/2020-03-25T04_59_47_611Z-debug.log

@nschonni

Copy link
Copy Markdown
Member Author

Thanks @MylesBorins, I wonder if it's updating the dependencies. I'll try swapping "install" to "ci" for the NPM command in the google build

@nschonni

Copy link
Copy Markdown
Member Author

/gcbrun

@nschonni

Copy link
Copy Markdown
Member Author

Yup, switching to ci for the GCB worked

@nschonni nschonni requested a review from MylesBorins March 25, 2020 20:25

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nschonni nschonni merged commit b1f2d60 into nodejs:master Mar 27, 2020
@nschonni nschonni deleted the yarn-to-npm branch March 27, 2020 00:49
@nschonni

Copy link
Copy Markdown
Member Author

Darn, just realized from the Dependabot updates, it left the registry url as yarnpkg in the lockfile. I'm going to send a followup to fix that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants