Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

chore: Add links to navbar.#38

Closed
mbj36 wants to merge 2 commits into
nodejs:masterfrom
mbj36:master
Closed

chore: Add links to navbar.#38
mbj36 wants to merge 2 commits into
nodejs:masterfrom
mbj36:master

Conversation

@mbj36

@mbj36 mbj36 commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@LaRuaNa LaRuaNa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keywordnew

Copy link
Copy Markdown
Contributor

Closes #28

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/components/header.tsx Outdated
Comment thread src/components/header.tsx Outdated
@mbj36

mbj36 commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

@MylesBorins Ran prettier on TS files and set semi to true

@amiller-gh amiller-gh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add some more styles on to this to make it pretty and then will pull it in 👍

@MylesBorins

Copy link
Copy Markdown
Contributor

/gcbrun

@MylesBorins

Copy link
Copy Markdown
Contributor

@ehabdevel

Copy link
Copy Markdown

Hi,
a quick review,
The hero heights is still hiding a big part in my 19" screen when scrolling down, just for nice looking which is not really practical.
I tried this:
{ --hero-height: 20rem; }
in my css console tab and it works fine.

*** Or it is better that the hero have to be hidden totally when scrolling down...

Thanks in advance,
Also I am here if help is needed...
best wishes,

@ahmadawais

Copy link
Copy Markdown
Member

@ehabdevel are you talking about the part shown below? I don't like it either. Makes reading the material extremely hard since it covers the text.

@MylesBorins

Copy link
Copy Markdown
Contributor

ping @amiller-gh

@MylesBorins

Copy link
Copy Markdown
Contributor

@mbj36 can you rebase?

@amiller-gh are you still planning to extend the styles on this?

Comment thread .prettierrc
@@ -1,5 +1,5 @@
{
"semi": false,
"semi": true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being handled in #90 — just sharing.

@mbj36

mbj36 commented Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

I am closing this in favour of #111

@mbj36 mbj36 closed this Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants