Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

chore: Add links to navbar. #38

Closed
mbj36 wants to merge 2 commits into from
Closed

chore: Add links to navbar. #38

mbj36 wants to merge 2 commits into from

Conversation

@mbj36
Copy link
Contributor

@mbj36 mbj36 commented Feb 13, 2019

No description provided.

LaRuaNa
LaRuaNa reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@LaRuaNa LaRuaNa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keywordnew
Copy link
Contributor

keywordnew commented Feb 14, 2019

Closes #28

MylesBorins
MylesBorins reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://storage.googleapis.com/staging.nodejs.dev/04526d1/index.html

MylesBorins
MylesBorins reviewed Feb 14, 2019
View reviewed changes
@mbj36
Copy link
Contributor Author

mbj36 commented Feb 14, 2019 •
edited
Loading

@MylesBorins Ran prettier on TS files and set semi to true

amiller-gh
amiller-gh suggested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@amiller-gh amiller-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add some more styles on to this to make it pretty and then will pull it in 👍

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 19, 2019

/gcbrun

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 19, 2019

https://storage.googleapis.com/staging.nodejs.dev/72115ed/index.html

@ehabdevel
Copy link

ehabdevel commented Feb 20, 2019

Hi,
a quick review,
The hero heights is still hiding a big part in my 19" screen when scrolling down, just for nice looking which is not really practical.
I tried this:
{ --hero-height: 20rem; }
in my css console tab and it works fine.

*** Or it is better that the hero have to be hidden totally when scrolling down...

Thanks in advance,
Also I am here if help is needed...
best wishes,

@ahmadawais
Copy link
Member

ahmadawais commented Feb 20, 2019

@ehabdevel are you talking about the part shown below? I don't like it either. Makes reading the material extremely hard since it covers the text.

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 20, 2019

ping @amiller-gh

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 22, 2019

@mbj36 can you rebase?

@amiller-gh are you still planning to extend the styles on this?

ahmadawais
ahmadawais reviewed Feb 22, 2019
View reviewed changes
.prettierrc
@@ -1,5 +1,5 @@
{
"semi": false,
"semi": true,
Copy link
Member

@ahmadawais ahmadawais Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being handled in #90 — just sharing.

@mbj36
Copy link
Contributor Author

mbj36 commented Feb 22, 2019

I am closing this in favour of #111

@mbj36 mbj36 closed this Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

6 more reviewers

@MylesBorins MylesBorins MylesBorins left review comments

@ahmadawais ahmadawais ahmadawais left review comments

@LaRuaNa LaRuaNa LaRuaNa left review comments

@ZYSzys ZYSzys ZYSzys left review comments

@amiller-gh amiller-gh amiller-gh requested changes

@willin willin willin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mbj36 @keywordnew @MylesBorins @ehabdevel @ahmadawais @willin @LaRuaNa @amiller-gh @ZYSzys