This repository was archived by the owner on Apr 26, 2024. It is now read-only.
fix Windows compatablity for commiting#339
Closed
nschonni wants to merge 2 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 39.92% 39.92%
=======================================
Files 22 22
Lines 273 273
Branches 62 62
=======================================
Hits 109 109
Misses 162 162
Partials 2 2Continue to review full report at Codecov.
|
nschonni
changed the title
Member
Author
|
Closing since #323 landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Working on a Windows machine for the previous PR, I was unable to push a branch because of the
pre-pushhook. Tracked down 2 known issues related to Windows with the current config and was able to push this without commenting out the hook for this.Related Issues