Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

feat(Learn): mark learn section title as read#3098

Merged
aymen94 merged 2 commits into
nodejs:mainfrom
shanpriyan:feat/mark-section-title-read
Dec 19, 2022
Merged

feat(Learn): mark learn section title as read#3098
aymen94 merged 2 commits into
nodejs:mainfrom
shanpriyan:feat/mark-section-title-read

Conversation

@shanpriyan

@shanpriyan shanpriyan commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

Description

Marked learn section title as read with a checkmark if all subsections are read.

Screencast.webm

Related Issues

Resolves #3097

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 66.02% // Head: 67.42% // Increases project coverage by +1.39% 🎉

Coverage data is based on head (e452b91) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3098      +/-   ##
==========================================
+ Coverage   66.02%   67.42%   +1.39%     
==========================================
  Files         118      145      +27     
  Lines        1351     1679     +328     
  Branches      342      397      +55     
==========================================
+ Hits          892     1132     +240     
- Misses        422      504      +82     
- Partials       37       43       +6     
Impacted Files Coverage Δ
src/templates/blog.tsx 0.00% <0.00%> (-100.00%) ⬇️
util-node/getNodeReleasesData.js 91.30% <0.00%> (-6.32%) ⬇️
src/__fixtures__/page.tsx 94.11% <0.00%> (-5.89%) ⬇️
src/pages/index.tsx 100.00% <0.00%> (ø)
src/templates/api.tsx 0.00% <0.00%> (ø)
src/templates/learn.tsx 100.00% <0.00%> (ø)
util-node/createSlug.js 100.00% <0.00%> (ø)
util-node/getNvmData.js 100.00% <0.00%> (ø)
src/hooks/useOnScreen.tsx 100.00% <0.00%> (ø)
src/pages/about/index.tsx 100.00% <0.00%> (ø)
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice little changes!

@aymen94 aymen94 merged commit 1394e9f into nodejs:main Dec 19, 2022
@shanpriyan shanpriyan deleted the feat/mark-section-title-read branch December 19, 2022 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark section title in learn as completed

4 participants