Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

feat(API) color index#3070

Merged
ovflowd merged 3 commits into
nodejs:mainfrom
AugustinMauroy:test
Dec 8, 2022
Merged

feat(API) color index#3070
ovflowd merged 3 commits into
nodejs:mainfrom
AugustinMauroy:test

Conversation

@AugustinMauroy

@AugustinMauroy AugustinMauroy commented Dec 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Before:

Capture d’écran 2022-12-04 à 15 54 54

Capture d’écran 2022-12-04 à 15 55 08

After:

Capture d’écran 2022-12-04 à 15 55 41

Capture d’écran 2022-12-04 à 15 55 24

Inspiration from Figma:

image

I don't have found more information on Figma

Related Issues

#2891

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy

AugustinMauroy commented Dec 4, 2022

Copy link
Copy Markdown
Member Author

I think an preview is no an bad idea 🤔

@codecov-commenter

codecov-commenter commented Dec 4, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 66.02% // Head: 68.07% // Increases project coverage by +2.05% 🎉

Coverage data is based on head (1a88502) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3070      +/-   ##
==========================================
+ Coverage   66.02%   68.07%   +2.05%     
==========================================
  Files         118      145      +27     
  Lines        1351     1654     +303     
  Branches      342      388      +46     
==========================================
+ Hits          892     1126     +234     
- Misses        422      485      +63     
- Partials       37       43       +6
Impacted Files Coverage Δ
src/templates/blog.tsx 0.00% <0.00%> (-100.00%) ⬇️
util-node/getNodeReleasesData.js 91.30% <0.00%> (-6.32%) ⬇️
src/__fixtures__/page.tsx 94.11% <0.00%> (-5.89%) ⬇️
src/pages/index.tsx 100.00% <0.00%> (ø)
src/templates/api.tsx 0.00% <0.00%> (ø)
src/templates/learn.tsx 100.00% <0.00%> (ø)
util-node/createSlug.js 100.00% <0.00%> (ø)
util-node/getNvmData.js 100.00% <0.00%> (ø)
src/hooks/useOnScreen.tsx 100.00% <0.00%> (ø)
src/pages/about/index.tsx 100.00% <0.00%> (ø)
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovflowd

ovflowd commented Dec 4, 2022

Copy link
Copy Markdown
Member

From which Figma you inspired yourself on these colors?

@ovflowd ovflowd added the create-preview Generate preview on staging.nodejs.dev label Dec 4, 2022
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Dec 4, 2022
@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/3070/

@AugustinMauroy

AugustinMauroy commented Dec 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Figma ref. link

@ovflowd

ovflowd commented Dec 4, 2022

Copy link
Copy Markdown
Member

Very interesting! I swear I didn't notice these parts of the Figma before 🤯

ovflowd
ovflowd approved these changes Dec 4, 2022
View reviewed changes

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these colors!

@AugustinMauroy

AugustinMauroy commented Dec 4, 2022

Copy link
Copy Markdown
Member Author

I love these colors!

Me too ♥️👌🏻

@ovflowd ovflowd merged commit da95e60 into nodejs:main Dec 8, 2022
@AugustinMauroy AugustinMauroy deleted the test branch January 12, 2023 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ovflowd ovflowd ovflowd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AugustinMauroy @codecov-commenter @ovflowd