Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Added external link to Axios library#296

Merged
MylesBorins merged 1 commit into
nodejs:masterfrom
Userbit:patch-3
Aug 16, 2019
Merged

Added external link to Axios library#296
MylesBorins merged 1 commit into
nodejs:masterfrom
Userbit:patch-3

Conversation

@Userbit

@Userbit Userbit commented Aug 13, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Aug 13, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@e37eb9d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #296   +/-   ##
=========================================
  Coverage          ?   39.92%           
=========================================
  Files             ?       22           
  Lines             ?      273           
  Branches          ?       62           
=========================================
  Hits              ?      109           
  Misses            ?      162           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37eb9d...dd63c7c. Read the comment docs.

@amiller-gh

Copy link
Copy Markdown
Member

Thank you for the link update!

I don't think any docs page concerning http requests (especially one that references 3rd party packages) is complete without mentioning node-fetch.

We may also consider updating this page to reflect the latest discussions around requests in Node.js by adding some context around the ongoing "Fetch in Core" conversation? nodejs/node#19393
https://docs.google.com/document/d/1tn_-0S_FG_sla81wFohi8Sc8YI5PJiTopEzSA7UaLKM/edit

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

Copy link
Copy Markdown
Contributor

I've rebased and force pushed to kick off travis again. unsure why it was locking up the way it did

@MylesBorins

Copy link
Copy Markdown
Contributor

/gcbrun

@MylesBorins MylesBorins merged commit eaa1664 into nodejs:master Aug 16, 2019
jonchurch pushed a commit to jonchurch/nodejs.dev that referenced this pull request Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants