Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

chore: Update commitlint/cli from 7.3.2 to 8.1.0#288

Merged
maddhruv merged 1 commit into
nodejs:masterfrom
Trott:update-commitlint
Jul 20, 2019
Merged

chore: Update commitlint/cli from 7.3.2 to 8.1.0#288
maddhruv merged 1 commit into
nodejs:masterfrom
Trott:update-commitlint

Conversation

@Trott

@Trott Trott commented Jul 20, 2019

Copy link
Copy Markdown
Member

Description

This eliminates npm audit complaints about commitlint dependencies.

Related Issues

maddhruv
maddhruv reviewed Jul 20, 2019
View reviewed changes
Comment thread gatsby-config.js Outdated
url: `${site.siteMetadata.siteUrlNoSlash}/${
edge.node.fields.slug
}`,
url: `${site.siteMetadata.siteUrlNoSlash}/${edge.node.fields.slug}`,

@maddhruv maddhruv Jul 20, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@maddhruv

maddhruv commented Jul 20, 2019

Copy link
Copy Markdown

The command "yarn --frozen-lockfile" failed and exited with 1 during .

@Trott

@Trott
chore: Update commitlint/cli from 7.3.2 to 8.1.0
db2c963 
This eliminates npm audit complaints about commitlint dependencies.
@Trott

Trott commented Jul 20, 2019

Copy link
Copy Markdown
Member Author

The command "yarn --frozen-lockfile" failed and exited with 1 during .

@Trott

Wow, I'm really good at forgetting use yarn in this repo. (Also good at forgetting that it only works with Node.js 10 and fails with Node,js 12, something that we should probably fix.)

Fixed. Force pushed.

@maddhruv

maddhruv commented Jul 20, 2019

Copy link
Copy Markdown

There are a hell lot of problems with yarn to work as fine with Node {x}
I don't know why Yarn was chosen in first place for this project

@codecov-io

codecov-io commented Jul 20, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@ec2af85). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage          ?   39.92%           
=========================================
  Files             ?       22           
  Lines             ?      273           
  Branches          ?       61           
=========================================
  Hits              ?      109           
  Misses            ?      163           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2af85...db2c963. Read the comment docs.

@maddhruv maddhruv merged commit 5e02810 into nodejs:master Jul 20, 2019
@Trott

Trott commented Jul 20, 2019

Copy link
Copy Markdown
Member Author

There are a hell lot of problems with yarn to work as fine with Node {x}
I don't know why Yarn was chosen in first place for this project

Seems to work fine for me as long as I remember to use it and not npm instead. 😀

jonchurch pushed a commit to jonchurch/nodejs.dev that referenced this pull request Sep 17, 2019
@Trott @jonchurch
chore: Update commitlint/cli from 7.3.2 to 8.1.0 (nodejs#288)
9695071 
This eliminates npm audit complaints about commitlint dependencies.
@Trott Trott deleted the update-commitlint branch January 18, 2022 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@maddhruv maddhruv maddhruv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott @maddhruv @codecov-io