Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Initial draft of socket programming with net module guide#286

Merged
benhalverson merged 7 commits into
nodejs:masterfrom
Ethan-Arrowood:net-module
Apr 29, 2020
Merged

Initial draft of socket programming with net module guide#286
benhalverson merged 7 commits into
nodejs:masterfrom
Ethan-Arrowood:net-module

Conversation

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

Description

This PR adds the initial draft for a guide to socket programming using the core net module

Related Issues

Closes #126

@codecov-io

codecov-io commented Jul 12, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@fbd5f8f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #286   +/-   ##
=========================================
  Coverage          ?   39.92%           
=========================================
  Files             ?       22           
  Lines             ?      273           
  Branches          ?       61           
=========================================
  Hits              ?      109           
  Misses            ?      163           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd5f8f...81763fe. Read the comment docs.

Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
@MylesBorins

Copy link
Copy Markdown
Contributor

@addaleax does this now LGTY?

@jonchurch jonchurch added the docs label Jan 31, 2020
@alexandrtovmach alexandrtovmach added the enhancement New feature or request label Apr 25, 2020
@alexandrtovmach

Copy link
Copy Markdown
Contributor

/gcbrun

@alexandrtovmach

Copy link
Copy Markdown
Contributor

@Ethan-Arrowood Please fix linter issues

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

Fixed errors but GC is failing for some reason? Not sure whats up with that

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM added some editorial changes and requests for a few links.

Feel free to ignore the change suggestions regarding 127.0.0.1 instead of localhost... I'm really on the fence about which is better

Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md
Comment thread src/documentation/0000-socket-programming-with-net-module/index.md Outdated
@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I'll make these changes tomorrow during work. I sorta forgot about this article 😅created the original issue over a year ago and opened the PR during my final semester of college 😂nonetheless glad we can finish it up!

I'll look into the localhost / 127.0.01 thing. if I can find a credible source of cross system reliability ill make the change otherwise I'll include a note that recommends the use of a Unix environment for the code snippets

@Ethan-Arrowood

Ethan-Arrowood commented Apr 28, 2020

Copy link
Copy Markdown
Contributor Author

A cursory look at some online posts says the localhost is more reliable. While 127.0.0.1 is the most common loopback, some individual's systems may be configured differently, but all mainstream OS's will have the right network files to redirect localhost string to whatever their system's loopback address is.

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

Rebased ✅

@benhalverson benhalverson merged commit 2525feb into nodejs:master Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add section on net module

7 participants