Initial draft of socket programming with net module guide#286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
=========================================
Coverage ? 39.92%
=========================================
Files ? 22
Lines ? 273
Branches ? 61
=========================================
Hits ? 109
Misses ? 163
Partials ? 1Continue to review full report at Codecov.
|
|
@addaleax does this now LGTY? |
|
/gcbrun |
|
@Ethan-Arrowood Please fix linter issues |
d5bf8da to
5d2c5cc
Compare
|
Fixed errors but GC is failing for some reason? Not sure whats up with that |
MylesBorins
left a comment
There was a problem hiding this comment.
Generally LGTM added some editorial changes and requests for a few links.
Feel free to ignore the change suggestions regarding 127.0.0.1 instead of localhost... I'm really on the fence about which is better
|
Thanks for the review! I'll make these changes tomorrow during work. I sorta forgot about this article 😅created the original issue over a year ago and opened the PR during my final semester of college 😂nonetheless glad we can finish it up! I'll look into the localhost / 127.0.01 thing. if I can find a credible source of cross system reliability ill make the change otherwise I'll include a note that recommends the use of a Unix environment for the code snippets |
|
A cursory look at some online posts says the |
…x.md Co-Authored-By: Myles Borins <myles.borins@gmail.com>
…x.md Co-Authored-By: Myles Borins <myles.borins@gmail.com>
…x.md Co-Authored-By: Myles Borins <myles.borins@gmail.com>
0b087b1 to
a3bd290
Compare
|
Rebased ✅ |
Description
This PR adds the initial draft for a guide to socket programming using the core
netmoduleRelated Issues
Closes #126