This repository was archived by the owner on Apr 26, 2024. It is now read-only.
feat(pages): removed deprecated pages, added new pages, updated existing ones#2742
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2742 +/- ##
==========================================
- Coverage 66.02% 65.68% -0.35%
==========================================
Files 118 122 +4
Lines 1351 1390 +39
Branches 342 352 +10
==========================================
+ Hits 892 913 +21
- Misses 422 440 +18
Partials 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
github-actions
Bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/2742/ |
| padding: 40px 30px 40px 0; | ||
|
|
||
| @media (max-width: 800px) { | ||
| @media (max-width: 900px) { |
Member
There was a problem hiding this comment.
Maybe we should have a sass variable for this value since it's used in multiple locations.
Member
Author
There was a problem hiding this comment.
Maybe we should have a sass variable for this value since it's used in multiple locations.
Potential for next PR 😋
Member
Author
benhalverson
approved these changes
Sep 12, 2022
Member
Author
|
Also, @benhalverson regarding the Code + Learn if @Trott or @joesepi believe we can remove them, I'd be more than happy for doing so hehe |
ovflowd
force-pushed
the
feat/add-all-nodejs-org-pages
branch
from
d475d03 to
9641029
Compare
ovflowd
force-pushed
the
feat/add-all-nodejs-org-pages
branch
from
0c994ba to
c4c6f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR syncs content from Nodejs.org by:
Finally this PR adjusts the following to make all this work:
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.