feat(css-modules): initial version of css modules#2676
Conversation
|
Note.: With this PR the |
|
Please find a preview at: https://staging.nodejs.dev/2676/ |
|
Update:
|
|
Please find a preview at: https://staging.nodejs.dev/2676/ |
|
Update:
Would gently ask a review from @benhalverson @rodion-arr @manishprivet @mikeesto |
Codecov Report
@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
- Coverage 88.25% 87.51% -0.75%
==========================================
Files 100 100
Lines 996 977 -19
Branches 276 252 -24
==========================================
- Hits 879 855 -24
- Misses 110 115 +5
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Please find a preview at: https://staging.nodejs.dev/2676/ |
|
I've noticed that |
|
Done, updated to the usage of SVG-only icons. Bundle reduced by around 200KB. And the initial content shifting is also reduced, as the icons don't need to be swapped via font family. |
|
Note.: I also enabled font-aliasing here to remove the sharp edges from fonts; it will give the impression on some screens that the font-weight got reduced, whereas it is just the font-aliasing algorithm that also changes from OS-to-OS and screen-to-screen. |
|
Please find a preview at: https://staging.nodejs.dev/2676/ |
mikeesto
left a comment
There was a problem hiding this comment.
Great job on this, a huge refactor. I spent some time comparing the preview to the live version and couldn't see any issues.
manishprivet
left a comment
There was a problem hiding this comment.
LGTM! Thank you for working on this
|
Thank you, @mikeesto @manishprivet just a heads-up for other minor changes that happened here:
I'm going to add tests on a follow-up PR as otherwise this PR will become way too massive. |
Description
This PR moves all the styles into CSS modules and removes unused components, styles and fixes other styles.
Related Issues
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.