This repository was archived by the owner on Apr 26, 2024. It is now read-only.
fix(search-bar): fixed search bar styling and made it exclusive to search-bar#2665
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2665 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 102 102
Lines 1064 1064
Branches 293 293
=======================================
Hits 919 919
Misses 139 139
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
github-actions
Bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/2665/ |
rodion-arr
approved these changes
Aug 22, 2022
rodion-arr
left a comment
rodion-arr
left a comment
Contributor
There was a problem hiding this comment.
Probably, if we are touching search, we can also fix the issue with search icon? It looks like it is not clickable and does not open search bar 😬
Member
Author
|
Maybe in a next PR as this PR is more like a hot fix? 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced by the last commit of #2654 that would misalign the search bar. This PR also corrects and ensures a fixed height for the navigation bar.
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.