This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix/broken links in learn quick start#2657
Merged
ovflowd merged 5 commits intoAug 21, 2022
Merged
Conversation
This fixes the issue of pages not being created due to typos in yaml or name of file not corresponding with info given in learn.yaml.
This fixes the issue of pages not being created due to a check in getYamlPageIdentifier() always causing the check to return false. Adjusted method used to .includes(/index.) to catch possible variants of <subfolder>/index files.
This fixes the issue of needing to possibly adjust links by hand in the future as the package `gatsby-plugin-catch-links` is already in use & kicks in when local links are used in markdown files.
ovflowd
approved these changes
Aug 19, 2022
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
Amazing changes! Thank you so much for your contributions! 🎉 
- Codewise looks good!
- Nice catch on the typos!
- Thanks for updating the links 👌
ovflowd
added
bug
Codecov Report
@@ Coverage Diff @@
## main #2657 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 103 103
Lines 1113 1113
Branches 310 310
=======================================
Hits 929 929
Misses 178 178
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.Description
These changes fix the issues connected to broken links as described in #2647.
In order to provide a clear understanding I've sliced the commits as small as possible.
Note: some changes would already get implemented with @ovflowd's introduce several fixes within the nodejs.dev (styles, links, caching, functionality). But wanted to provide my changes for reference. So please feel free to include these in another PR. :)
/index.defaulted tofalse)/learn& used local links in order to prevent future breaks :) (used package was already in place)Related Issues
Fixes #2647 & broken pages in general