This repository was archived by the owner on Apr 26, 2024. It is now read-only.
fix(i18n/config): fix hrefLang for zh-cn & zh-tw#2652
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2652 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 103 103
Lines 1113 1113
Branches 310 310
=======================================
Hits 929 929
Misses 178 178
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Kunal0007
approved these changes
Aug 18, 2022
ovflowd
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Description
The
hrefLangcode for "Simplified Chinese" should bezh-Hans, whilezh-Hantfor "Traditional Chinese".See references under "Script codes" section on https://hreflang.org/list-of-hreflang-codes/ for "Han (Simplified variant)" and Han (Traditional variant).
Related Issues
This PR tries to fix a mistake in PR #2644