Update configuration file with relevant I18n data#2644
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2644 +/- ##
=======================================
Coverage 84.33% 84.33%
=======================================
Files 100 100
Lines 1117 1117
Branches 313 313
=======================================
Hits 942 942
Misses 169 169
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
That's great! Thank you so much for the contribution, Kunal! 💖
|
ref : #2639 |
| "dateFormat": "DD.MM.YYYY", | ||
| "hrefLang": "", | ||
| "dateFormat": "YYYY.MM.DD", | ||
| "hrefLang": "zh-Hant", |
There was a problem hiding this comment.
Sorry to interrupt, but I'm afraid there's a tiny mistake 😂
The t in zh-Hant means "traditional" while s in zh-Hans means "Simplified".
There was a problem hiding this comment.
I just wrote a possible fix, hoping this might help. 😄 main...zedifen:i18n-ch-fix
There was a problem hiding this comment.
Oh, gotcha! Could you open a PR? 🙈
There was a problem hiding this comment.
Sorry, I got a little confused 😅.
There was a problem hiding this comment.
Oh, gotcha! Could you open a PR? 🙈
Ok, I've opened a PR. 😃
Sorry, I got a little confused 😅.
Oh, it's alright 😆 There are lots of variants of Chinese, and their codes do look quite similar
6 participants
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.Description
Updated
src/i18n/configs.json filewith correct metadata from all the languages.Updated data missing from all these languages, such as their date formats, if those languages are RTL (Right-to-left) or LTR (Left-to-right), and their hreflangs.
Reference:
hreflang:- https://hreflang.org/list-of-hreflang-codes/
Date format and langDir:- https://meta.wikimedia.org/wiki/Date_formats_in_various_languages
Related Issues
Fixes #2619