This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fr homepage#2639
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2639 +/- ##
=======================================
Coverage 68.83% 68.83%
=======================================
Files 119 119
Lines 1325 1325
Branches 332 332
=======================================
Hits 912 912
Misses 379 379
Partials 34 34 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Aug 15, 2022
Merged
Merged
github-actions
Bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/2639/ |
5 tasks
benhalverson
approved these changes
Aug 18, 2022
ovflowd
reviewed
Aug 18, 2022
ovflowd
suggested changes
Aug 22, 2022
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
This needs to get merged first, otherwise the fr.json will break apart.
@AugustinMauroy once that PR gets merged, I would recommend to update the translation keys values for fr.json
ovflowd
reviewed
Aug 22, 2022
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
The base-PR got merged, @AugustinMauroy please feel free to update this PR adding the translated keys from en.json into fr.json.
Thank you!
ovflowd
reviewed
Sep 4, 2022
ovflowd
reviewed
Sep 4, 2022
vdeturckheim
suggested changes
Sep 7, 2022
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
ovflowd
approved these changes
Sep 7, 2022
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
LGTM! Please just double-check that you have the same keys from en.json here, otherwise we will have some text missing.
Otherwise, ready to get merged.
vdeturckheim
suggested changes
Sep 8, 2022
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
Co-authored-by: Vladimir de Turckheim <vdeturckheim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fr homepage
@nodejs/nodejs-fr
tthis pull request can be merge