Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

i18n(fr): added french pages#2620

Merged
ovflowd merged 63 commits into
nodejs:mainfrom
AugustinMauroy:main
Sep 4, 2022
Merged

i18n(fr): added french pages#2620
ovflowd merged 63 commits into
nodejs:mainfrom
AugustinMauroy:main

Conversation

@AugustinMauroy

@AugustinMauroy AugustinMauroy commented Aug 11, 2022

Copy link
Copy Markdown
Member

Translation: FR

French translation of about.

Preview

this pull request can't be merge because it depends on #2639

@AugustinMauroy AugustinMauroy changed the title Translation: FR (About) FR About Aug 12, 2022
@AugustinMauroy AugustinMauroy changed the title FR About Fr About Aug 12, 2022
Comment thread content/about/about.fr.md Outdated
@codecov-commenter

codecov-commenter commented Aug 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2620 (18ec497) into main (e881d95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2620   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         119      119           
  Lines        1325     1325           
  Branches      333      333           
=======================================
  Hits          912      912           
  Misses        379      379           
  Partials       34       34           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread src/i18n/config.json
@ovflowd

ovflowd commented Aug 12, 2022

Copy link
Copy Markdown
Member

I'm seeing errors in your builds, don't forget to put your text on the YAML surrounded by quotes. Eg.:

description: "My description here"

Text usually needs to be quoted if contains special characters.

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're doing already a lot of commits, but we're getting there!

Thank you so much for these contributions!

Comment thread content/about/about.fr.md Outdated
Comment thread content/about/resources.fr.md Outdated
Comment thread content/homepage/index.fr.md Outdated

@kapouer kapouer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots and lots of duplicated strings.
Some mistakes, some typos, some translation woes, and some forgotten words.

Comment thread content/about/about.fr.md Outdated
Comment thread content/about/about.fr.md Outdated
Comment thread content/about/about.fr.md Outdated
Comment thread content/about/about.fr.md Outdated
Comment thread content/about/about.fr.md Outdated
Comment thread content/about/working-groups.fr.md Outdated
Comment thread content/about/working-groups.fr.md Outdated
Comment thread content/about/working-groups.fr.md Outdated
Comment thread content/about/working-groups.fr.md Outdated
Comment thread content/about/working-groups.fr.md

@kapouer kapouer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que c'est normal qu'il y a des lignes ou des fragments en double ?
Je ne comprends pas bien ce qui se passe à ce niveau là.

@ovflowd

ovflowd commented Aug 18, 2022

Copy link
Copy Markdown
Member

@AugustinMauroy looks great! I think we're finally close to get this merged.

Just a final review from @nodejs/nodejs-fr 🙏

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding these typos I mentioned, double-check the English version of your files 😄 (Just to ensure the title field is correct).

Besides, thank you so much for your contributions and your patience!

Comment thread content/about/releases.fr.md Outdated
Comment thread content/about/resources.fr.md Outdated
Comment thread content/about/security.fr.md Outdated
Comment thread content/about/trademark.fr.md Outdated
Comment thread content/about/working-groups.fr.md Outdated
@ovflowd

ovflowd commented Aug 21, 2022

Copy link
Copy Markdown
Member

Regarding these typos I mentioned, double-check the English version of your files 😄 (Just to ensure the title field is correct).

@AugustinMauroy I'm still waiting for those changes :)

@AugustinMauroy

Copy link
Copy Markdown
Member Author

I'm back from vacation. I am correcting all the mistakes on the pr.

@ovflowd

@ovflowd

ovflowd commented Aug 22, 2022

Copy link
Copy Markdown
Member

Looks good to me! @nodejs/nodejs-fr could you folks double-check here?

@ovflowd

ovflowd commented Aug 26, 2022

Copy link
Copy Markdown
Member

@AugustinMauroy could you delete the trademark markdown file? We removed that page from the website 🙇

After this I think we're good to merge :)

@AugustinMauroy

Copy link
Copy Markdown
Member Author

@ovflowd trademark was remove

@benhalverson

Copy link
Copy Markdown
Member

I was going to merge this but github is telling me a conflict exists but doesn't list which file.

@AugustinMauroy

Copy link
Copy Markdown
Member Author

@benhalverson its strange ?

@benhalverson

Copy link
Copy Markdown
Member

@benhalverson its strange ?

Yes

conflict

@AugustinMauroy

Copy link
Copy Markdown
Member Author

@benhalverson normally we can merge this pr

@ovflowd ovflowd changed the title Fr About i18n(fr): added french pages Sep 4, 2022
@ovflowd ovflowd merged commit 5968103 into nodejs:main Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants