Codecov Report

❗ No coverage uploaded for pull request base (master@df0abde). Click here to learn what that means.
The diff coverage is 45.16%.

@@            Coverage Diff            @@
##             master     #240   +/-   ##
=========================================
  Coverage          ?   40.07%           
=========================================
  Files             ?       22           
  Lines             ?      272           
  Branches          ?       61           
=========================================
  Hits              ?      109           
  Misses            ?      162           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df0abde...fa996d0. Read the comment docs.

@kevjin Feel free to run the following command to build a staging demo whenever there are visual changes to be tested.

Just type the following in a comment. It means Google Cloud Build Run.

/gcbrun

/gcbrun

Per /gcbrun, just friendly note that In a previous PR (#222), I inquired about gcbrun v.s. required access. It might be collaborator-only to build a staging given this comment(#222 (review)), but not 💯 sure:

Can I try /gcbrun too? Not sure how the access stuff works.

I wasn't not too sure, either. But considering that your comment did not trigger a build, I think you need to be a collaborator to do so.

Though, still haven't since the staging URL shown from @ahmadawais's previous gcbrun attempt though, and he's a member of the project. 🤔

/gcbrun

@ahmadawais weird that /gcbrun still didn't work. Can we try one more time, or maybe reset its configuration for the project (not sure how it's set up)

/gcbrun

@MylesBorins can you help here? The /gcbrun is not posting the staging link

github actions doesn't run for PRs from a fork which is why the URL hasn't posted

The URLs are deterministic though

staging example is https://storage.googleapis.com/staging.nodejs.dev/fa996d0/index.html