/gcbrun

Eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/7344727/index.html

Codecov Report

❗ No coverage uploaded for pull request base (master@d1208ff). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #222   +/-   ##
=========================================
  Coverage          ?   38.81%           
=========================================
  Files             ?       20           
  Lines             ?      237           
  Branches          ?       56           
=========================================
  Hits              ?       92           
  Misses            ?      144           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1208ff...085f345. Read the comment docs.

nit: Can we use a dynamic import in the Layout.tsx component instead?

@sagirk, the Layout.tsx is indeed a much more appropriate place to do dynamic import of the polyfill within useEffect. Updated. PTAL? Looking forwards to testing in staging again.

Observed a TS syntax message in quote below. Tied to resolve w. npm install @types/intersection-observer, but intersection-observer type is not available. What are your thoughts? Since this is just a TS script warning, I'd vote to do a follow-up to address it.

Error:(26, 14) TS7016: Could not find a declaration file for module 'intersection-observer'. '/nodejs.dev/node_modules/intersection-observer/intersection-observer.js' implicitly has an 'any' type.
  Try `npm install @types/intersection-observer` if it exists or add a new declaration (.d.ts) file containing `declare module 'intersection-observer';`

P.S.: Can I try /gcbrun too? Not sure how the access stuff works.

/gcbrun

Eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/085f345/index.html

@sagirk et al, friendly FYI that I’ve tested the staging on iPhone and confirmed the nav menu title color is transitioning correctly on my test.

Ping / @sagirk