-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
|
@imbhargav5 See if you find the It has been used here: https://github.com/nodejs/nodejs.dev/blob/master/src/components/layout.tsx#L31-L55. |
|
Sorry this is taking a touch longer. I fell sick last week. Will put in time this weekend. Thanks!! |
c68d293 to
8adb53a
Compare
|
Here is a preview of what it looks like right now. I had to go for a different TOC component because structurally, it needs to be an immediate child of the I feel like there is some duplication, so if you have any ideas on how I can restructure this, I would love to hear them very much. |
|
/gcbrun |
|
@imbhargav5 Nice. Some issues I see.
|
|
/gcbrun |
|
Take a look at this document's right side navigation for inspiration → https://docs.microsoft.com/en-us/teamblog/announcing-open-specifications-migration#redirection-for-msdn The links change visually when clicked and selected. |
|
Lovely, quite excited about this PR :] Just noticed in @imbhargav5 For inspiration see also: https://docs.gitlab.com/ee/README.html |
|
@LaRuaNa It seems like I made a typo. I put in |
|
@ahmadawais How do you think I can do visual changes on click? 🤔 TOC ul and li items are mainly from the html string set with |
|
Yes, you can target all sorts of stuff with CSS. Right now there's no interaction when you hover the links. Use the same hover animations as used in the content. Find them in the layout.css file. |
|
/gcbrun |
|
/gcbrun eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/f849ca9/index.html |
|
What's the status of this? /gcbrun again so we can preview eventual staging example will be on https://storage.googleapis.com/staging.nodejs.dev/$SHA/index.html |
|
Should this be closed? |
|
/preview |
|
Please find a preview at: https://staging.nodejs.dev/199/ |
|
/preview |
|
Please find a preview at: https://staging.nodejs.dev/199/ |
|
Hi 👋 Sorry I lost track of this. Struggling for time for a while now. |
|
Was using old design therefore closing PR |



Description
This PR is about adding a right rail of TOC on desktops only. I am trying to minimise the number of divs I add for the sake of layout purposes. Please provide feedback to this draft PR.
Related Issues
This PR attempts to fix #192