Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@BeniCheni
Copy link
Contributor

@BeniCheni BeniCheni commented Mar 5, 2019

Refs #163:

  • Upgrade to emotion 10
  • Adapt emotion in header & pagination components.

P.S.: Also observed opportunities converting styles by class names to use emotion in some components, but wanted to keep the PR small. Will open PR(s) again, once the pattern passes review in this PR.

@mbj36
Copy link
Contributor

mbj36 commented Mar 5, 2019

/gcbrun

Copy link
Contributor

@sagirk sagirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@sagirk
Copy link
Contributor

sagirk commented Mar 6, 2019

The file src/components/pagination.tsx and associated tests may run into conflicts with #157, since it touches these files too.

Will wait for #157 to be merged before landing this.

@MylesBorins
Copy link
Contributor

@BeniCheni
Copy link
Contributor Author

iPhone and desktop looked okay with some testing in staging on my end.

@sagirk sagirk merged commit d986949 into nodejs:master Mar 7, 2019
@BeniCheni BeniCheni deleted the emotion-10 branch March 8, 2019 02:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants