This repository was archived by the owner on Apr 26, 2024. It is now read-only.
style: Adjust Header's padding below 380px #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeniCheni
changed the title
BeniCheni
changed the title
Contributor
|
@BeniCheni There's a lot of noise in this PR 'coz of the formatting changes. Can we please have only your changes, so its easier to review? FYI, there's a pending PR which reformats the codebase with prettier/tslint. It is waiting on #157 to land before it gets merged. |
Contributor
Author
Contributor
|
/gcbrun |
Member
|
Thank you ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking out responsive styles, observed a style bug that below 380px, the header nav items would display in an odd layout, which would cause UX issue like the hamburger menu wouldn’t open. Tried out this PR to:
emotionfor styles in header's JSX so that it can support existing style code and hook into media queryupdate code format with "format" script.Before Fix
With Fix @ 320px breakpoint (common like the legacy iPhone 5)