This repository was archived by the owner on Apr 26, 2024. It is now read-only.
fix: Include defaults to be explicit and turn off jsxBracketSameLine#155
Closed
sagirk wants to merge 1 commit into
Closed
fix: Include defaults to be explicit and turn off jsxBracketSameLine#155sagirk wants to merge 1 commit into
jsxBracketSameLine#155sagirk wants to merge 1 commit into
Conversation
- As agreed in the website-redesign meeting on 28-FEB-2019, it is recommended to include the default settings too in our prettier config to explicitly state the project's choices - The existing config remains as is, with the exception of `jsxBracketSameLine` which is turned off Refs: https://github.com/nodejs/nodejs.dev/issues/44
Contributor
Author
|
Closing in favour of #153. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed in the website-redesign meeting on 28-FEB-2019, it is
recommended to include the default settings too in our prettier config
to explicitly state the project's choices
The existing config remains as is, with the exception of
jsxBracketSameLinewhich is turned offRefs: https://github.com/nodejs/nodejs.dev/issues/44