This repository was archived by the owner on Apr 26, 2024. It is now read-only.
feat: New Prettier rules. #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
#155 follows it up by including the defaults too. |
Member
Author
|
Oh lol, we both did a PR at the same time. I just added all the defaults. Feel free to close that one. Thanks for the review. @sagirk I think I'll need one again 👍 |
Contributor
|
Hah, no probs. Closed the other one. 👍 Thanks for taking this up! 💚 |
Member
Author
|
I'm going to merge this tonight. Reviews welcomed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in today's meeting, this is the new set of rules as discussed based on #90. Looking forward, peace! ✌️