This repository was archived by the owner on Apr 26, 2024. It is now read-only.
docs: rework Buffer page#1388
Merged
Merged
Conversation
- Remove wildly misleading text about how Buffers in Node.js are related to the concept of buffering - Talk about UTF-8 instead of Unicode when UTF-8 is what the text is referring to and mention that it is dangerous to act as if bytes in a Buffer and characters are in 1:1 correspondence - Recommend using standardized JS methods instead of Node.js-specific ones where possible Refs: nodejs#1387 (review)
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 64 64
Lines 732 732
Branches 214 214
=======================================
Hits 624 624
Misses 106 106
Partials 2 2 Continue to review full report at Codecov.
|
Contributor
|
You should add your name to |
Member
Author
|
@bl-ue Thank you, done :) |
bl-ue
reviewed
Jun 6, 2021
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Contributor
|
You know, these docs look like a rich opportunity for grammatical expertise — I'll improve them in my spare time 🤔 |
bl-ue
approved these changes
Jun 6, 2021
Trott
reviewed
Jun 6, 2021
Trott
approved these changes
Jun 6, 2021
bnb
approved these changes
Jun 7, 2021
Co-authored-by: Rich Trott <rtrott@gmail.com>
panva
approved these changes
Jun 7, 2021
benhalverson
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
related to the concept of buffering (they are not!)
is referring to and mention that it is dangerous to act as if
bytes in a Buffer and characters are in 1:1 correspondence (they are not!)
Node.js-specific ones where possible
Related Issues
Refs: #1387 (review)