This repository was archived by the owner on Apr 26, 2024. It is now read-only.
docs: Fix description for buffer copy parameter#1387
Closed
alissonsv wants to merge 1 commit into
Closed
Conversation
Member
|
@nodejs/buffer |
addaleax
approved these changes
Jun 6, 2021
addaleax
added a commit
to addaleax/nodejs.dev
that referenced
this pull request
Jun 6, 2021
- Remove wildly misleading text about how Buffers in Node.js are related to the concept of buffering - Talk about UTF-8 instead of Unicode when UTF-8 is what the text is referring to and mention that it is dangerous to act as if bytes in a Buffer and characters are in 1:1 correspondence - Recommend using standardized JS methods instead of Node.js-specific ones where possible Refs: nodejs#1387 (review)
addaleax
added a commit
to addaleax/nodejs.dev
that referenced
this pull request
Jun 6, 2021
- Remove wildly misleading text about how Buffers in Node.js are related to the concept of buffering - Talk about UTF-8 instead of Unicode when UTF-8 is what the text is referring to and mention that it is dangerous to act as if bytes in a Buffer and characters are in 1:1 correspondence - Recommend using standardized JS methods instead of Node.js-specific ones where possible Refs: nodejs#1387 (review)
Author
|
Check #1388, she did a waaaay better job 😁 |
benhalverson
pushed a commit
that referenced
this pull request
Jun 8, 2021
- Remove wildly misleading text about how Buffers in Node.js are related to the concept of buffering - Talk about UTF-8 instead of Unicode when UTF-8 is what the text is referring to and mention that it is dangerous to act as if bytes in a Buffer and characters are in 1:1 correspondence - Recommend using standardized JS methods instead of Node.js-specific ones where possible Refs: #1387 (review)
kevindavies8
added a commit
to kevindavies8/nodejs.dev-for-full-stack-developer
that referenced
this pull request
Aug 24, 2022
- Remove wildly misleading text about how Buffers in Node.js are related to the concept of buffering - Talk about UTF-8 instead of Unicode when UTF-8 is what the text is referring to and mention that it is dangerous to act as if bytes in a Buffer and characters are in 1:1 correspondence - Recommend using standardized JS methods instead of Node.js-specific ones where possible Refs: nodejs/nodejs.dev#1387 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect description for the parameter