Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Added Working Groups Page#1345

Merged
benhalverson merged 9 commits into
nodejs:mainfrom
sejaljain123:workingGroups
Jun 18, 2021
Merged

Added Working Groups Page#1345
benhalverson merged 9 commits into
nodejs:mainfrom
sejaljain123:workingGroups

Conversation

@sejaljain123

Copy link
Copy Markdown
Contributor

Description

Closes #1340

Related Issues

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 20, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label May 20, 2021
@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1345/

@codecov-commenter

codecov-commenter commented May 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1345 (dc2f795) into main (6284ad9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
+ Coverage   85.76%   85.87%   +0.10%     
==========================================
  Files          71       72       +1     
  Lines         780      786       +6     
  Branches      216      216              
==========================================
+ Hits          669      675       +6     
  Misses        111      111              
Impacted Files Coverage Δ
src/pages/working-groups.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6284ad9...dc2f795. Read the comment docs.

Comment thread content/about/working-groups.md Outdated
Comment thread .remarkrc
Comment thread gatsby-node.js Outdated
@joesepi

joesepi commented May 21, 2021

Copy link
Copy Markdown
Member

How do I preview this page? Does it include the left sidebar? Thanks!

@rodion-arr

Copy link
Copy Markdown
Contributor

@MrJithil

Copy link
Copy Markdown
Member

@sejaljain123 Can I resolve the conflict if you are busy. In case you get some time to look in this PR, please resolve the conflicts, so that we can merge it.

CC: @benhalverson

@manishprivet

Copy link
Copy Markdown
Member

@sejaljain123 You need to resolve the conflicts and update the PR with the new Sidebar on the page, and the createGeneralPageData in tests.

I think you can refer to this commit for what needs to be changed.

bc91024

@sejaljain123

Copy link
Copy Markdown
Contributor Author

@sejaljain123 You need to resolve the conflicts and update the PR with the new Sidebar on the page, and the createGeneralPageData in tests.

I think you can refer to this commit for what needs to be changed.

bc91024

Okay , I'll do it by today. Sorry for the delay.

@manishprivet manishprivet added create-preview Generate preview on staging.nodejs.dev and removed create-preview Generate preview on staging.nodejs.dev labels Jun 18, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Jun 18, 2021
@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1345/

@benhalverson benhalverson merged commit b9d783e into nodejs:main Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Working Groups page

8 participants