feat: 🎸 Added governance page#1336
Conversation
github-actions
Bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/1336/ |
|
Direct link https://staging.nodejs.dev/1336/governance/ |
benhalverson
force-pushed
the
governance-page
branch
from
7050137 to
bd58c4b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1336 +/- ##
==========================================
+ Coverage 86.22% 86.32% +0.10%
==========================================
Files 68 69 +1
Lines 762 768 +6
Branches 218 218
==========================================
+ Hits 657 663 +6
Misses 105 105
Continue to review full report at Codecov.
|
| }, | ||
| }); | ||
|
|
||
| export const createGovernanceData = (): Page => ({ |
There was a problem hiding this comment.
I've noticed that apart from this, #1345, #1336, #1298, #1297 and #1296 use the exact same data for testing but use different function name. And I think it'll be created again for any new static page that we're going to add in issues like #1341.
I think we can keep a generic function for this type of PRs. Maybe we can change the function name to a generic one here, and then use it as an example for all other old / upcoming PRs.
|
Needs left sidebar. Thanks!! |
benhalverson
force-pushed
the
governance-page
branch
from
c1ed71c to
64bc5a7
Compare
github-actions
Bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/1336/ |
5 participants
Description
Adding /governance page
The existing page for nodejs.org is https://nodejs.org/en/about/governance/