Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Added security page#1297

Merged
manishprivet merged 16 commits into
nodejs:mainfrom
parthlaw:security
Jun 19, 2021
Merged

Added security page#1297
manishprivet merged 16 commits into
nodejs:mainfrom
parthlaw:security

Conversation

@parthlaw

@parthlaw parthlaw commented May 7, 2021

Copy link
Copy Markdown
Contributor

closes #1292
Added security page

@parthlaw

parthlaw commented May 7, 2021

Copy link
Copy Markdown
Contributor Author

/preview

@github-actions

github-actions Bot commented May 7, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1297/

benhalverson
benhalverson reviewed May 7, 2021
View reviewed changes
Comment thread .remarkignore Outdated
benhalverson
benhalverson reviewed May 7, 2021
View reviewed changes
Comment thread src/pages/security.tsx Outdated
@manishprivet manishprivet mentioned this pull request May 20, 2021
Merged
@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 20, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label May 20, 2021
@github-actions

github-actions Bot commented May 20, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1297/

@joesepi

joesepi commented May 21, 2021

Copy link
Copy Markdown
Member

Please find a preview at: https://staging.nodejs.dev/1297/

What is the URL to preview this work directly? This preview link still has a security link in the footer that takes me to nodejs.org. Thanks!

@rodion-arr

rodion-arr commented May 21, 2021

Copy link
Copy Markdown
Contributor

@joesepi https://staging.nodejs.dev/1297/security/

@benhalverson

benhalverson commented Jun 17, 2021

Copy link
Copy Markdown
Member

@parthlaw can you fix the conflicts and add in the <AboutPageSideNavBar />

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Jun 18, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Jun 18, 2021
@codecov-commenter

codecov-commenter commented Jun 18, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1297 (308a0af) into main (b9d783e) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   85.87%   85.98%   +0.10%     
==========================================
  Files          72       73       +1     
  Lines         786      792       +6     
  Branches      216      216              
==========================================
+ Hits          675      681       +6     
  Misses        111      111
Impacted Files Coverage Δ
src/components/AboutPageSideNavBar/index.tsx 90.90% <ø> (ø)
src/components/Footer/index.tsx 100.00% <ø> (ø)
src/pages/security.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d783e...308a0af. Read the comment docs.

@github-actions

github-actions Bot commented Jun 18, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1297/

@manishprivet manishprivet added the create-preview Generate preview on staging.nodejs.dev label Jun 18, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Jun 18, 2021
@github-actions

github-actions Bot commented Jun 18, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1297/

manishprivet
manishprivet suggested changes Jun 18, 2021
View reviewed changes
Comment thread test/pages/security.test.tsx Outdated
@manishprivet manishprivet mentioned this pull request Jun 19, 2021
Merged
@manishprivet manishprivet added the create-preview Generate preview on staging.nodejs.dev label Jun 19, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Jun 19, 2021
@github-actions

github-actions Bot commented Jun 19, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1297/

@manishprivet manishprivet merged commit 8d49750 into nodejs:main Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@benhalverson benhalverson benhalverson left review comments

@manishprivet manishprivet manishprivet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Security page

6 participants

@parthlaw @joesepi @rodion-arr @benhalverson @codecov-commenter @manishprivet