Added Privacy Policy Page#1296
Conversation
|
/preview |
|
Please find a preview at: https://staging.nodejs.dev/1296/ |
|
Thanks for the contribution @poorvi-vaish |
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 89.82% 89.91% +0.08%
==========================================
Files 63 64 +1
Lines 688 694 +6
Branches 203 203
==========================================
+ Hits 618 624 +6
Misses 70 70
Continue to review full report at Codecov.
|
|
Please find a preview at: https://staging.nodejs.dev/1296/ |
|
/preview |
|
@joesepi @designMoreWeb Any thoughts? |
|
Can you add the original authors to the authors field? |
benhalverson
left a comment
There was a problem hiding this comment.
After the conflict is addressed this is ok to merge 👍🏻
|
We want both changes.... The changes from the master branch is <section className="bottom-info">
<RandomContributor />
</section>and your change to the updated link <Link className="footer__link" to="/privacy">
Privacy Policy
</Link> |
This reverts commit 9e37b50.
|
Please find a preview at: https://staging.nodejs.dev/1296/ |
|
To align with nodejs.org, the layout should include any of the About left sidebar. This is being implemented in other ways by @benhalverson and @MrJithil. See other open PRs now and also see https://nodejs.org/en/about/privacy/ to understand what I mean here. Thanks!!! |
|
Please find a preview at: https://staging.nodejs.dev/1296/ |
|
Superseded by #1428 |
Closes #1294