Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Added Privacy Policy Page#1296

Closed
poorvi-vaish wants to merge 23 commits into
nodejs:mainfrom
poorvi-vaish:policypage
Closed

Added Privacy Policy Page#1296
poorvi-vaish wants to merge 23 commits into
nodejs:mainfrom
poorvi-vaish:policypage

Conversation

@poorvi-vaish

@poorvi-vaish poorvi-vaish commented May 7, 2021

Copy link
Copy Markdown
Contributor

Closes #1294

@poorvi-vaish

Copy link
Copy Markdown
Contributor Author

/preview

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 7, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label May 7, 2021
@github-actions

github-actions Bot commented May 7, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1296/

Comment thread .remarkignore Outdated
Comment thread content/about/privacy.md
@benhalverson

Copy link
Copy Markdown
Member

Thanks for the contribution @poorvi-vaish
Can you please add a test for this page?

@codecov-commenter

codecov-commenter commented May 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1296 (cea6ebc) into master (09ddbad) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
+ Coverage   89.82%   89.91%   +0.08%     
==========================================
  Files          63       64       +1     
  Lines         688      694       +6     
  Branches      203      203              
==========================================
+ Hits          618      624       +6     
  Misses         70       70              
Impacted Files Coverage Δ
src/components/Footer/index.tsx 100.00% <ø> (ø)
src/pages/privacy.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ddbad...cea6ebc. Read the comment docs.

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 9, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label May 9, 2021
@github-actions

github-actions Bot commented May 9, 2021

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1296/

@poorvi-vaish

Copy link
Copy Markdown
Contributor Author

/preview

@benhalverson

Copy link
Copy Markdown
Member

@joesepi @designMoreWeb Any thoughts?

@benhalverson

Copy link
Copy Markdown
Member

Can you add the original authors to the authors field?

@poorvi-vaish poorvi-vaish requested a review from benhalverson May 18, 2021 07:03

@benhalverson benhalverson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the conflict is addressed this is ok to merge 👍🏻

@benhalverson

Copy link
Copy Markdown
Member

We want both changes.... The changes from the master branch is

  <section className="bottom-info">
    <RandomContributor />
  </section>

and your change to the updated link

<Link className="footer__link" to="/privacy">
  Privacy Policy
</Link>

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 21, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label May 21, 2021
Comment thread gatsby-node.js
@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 21, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label May 21, 2021
@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1296/

@joesepi

joesepi commented May 21, 2021

Copy link
Copy Markdown
Member

To align with nodejs.org, the layout should include any of the About left sidebar. This is being implemented in other ways by @benhalverson and @MrJithil. See other open PRs now and also see https://nodejs.org/en/about/privacy/ to understand what I mean here. Thanks!!!

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Jun 13, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Jun 13, 2021
@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1296/

@benhalverson

Copy link
Copy Markdown
Member

Superseded by #1428

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy policy page

5 participants