This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Enforce types checking#1242
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
+ Coverage 57.96% 58.13% +0.17%
==========================================
Files 60 60
Lines 716 719 +3
Branches 216 217 +1
==========================================
+ Hits 415 418 +3
Misses 294 294
Partials 7 7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi Team!
I found that types was not checked as part of
lintjob and there was quite a few places that was violating existed interfaces.So this PR is some kind of proposal to enable strict types checking in the project. Anyway why we use Typescript without this? :)
In scope:
type-checknpm script along with linter@typespackages(Had to recreate the fork, sorry for the noise. This is a copy of #1212 from new branch)