Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 583aed9

Browse files
Kunal0007Kunal0007
authored
Merge branch 'main' into i18nconfig
2 parents d27874d + 9d4b2cc commit 583aed9

30 files changed

Lines changed: 158 additions & 885 deletions

‎.eslintrc.js‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
module.exports = {
2-
extends: [
3-
'airbnb',
4-
'plugin:prettier/recommended',
5-
'plugin:storybook/recommended',
6-
],
2+
extends: ['airbnb', 'plugin:prettier/recommended'],
73
env: {
84
browser: true,
95
node: true,

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Please follow this check list to ensure that you've followed all items before op
1313
- [ ] I have run `npm run lint:js -- --fix` and/or `npm run lint:md -- --fix` for my JavaScript and/or Markdown changes.
1414
- This is important as most of the cases your code changes might not be correctly linted
1515
- [ ] I have run `npm run test` to check if all tests are passing, and/or `npm run test -- -u` to update snapshots if I created and/or updated React Components.
16-
- [ ] I have checked that the build works locally and that `npm run build` and `npm run build-storybook` work fine.
16+
- [ ] I have checked that the build works locally and that `npm run build` work fine.
1717
- [ ] I've covered new added functionality with unit tests if necessary.
1818

1919
## Description

‎.github/workflows/gatsby.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,3 @@ jobs:
2020

2121
- name: Run Gatsby Build
2222
run: npm run build-ci
23-
24-
- name: Run Storybook Build
25-
run: npm run build-storybook

‎.github/workflows/generate-preview.yml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ jobs:
4747
env:
4848
PATH_PREFIX: ${{ github.event.pull_request.number }}/
4949

50-
- name: Run Storybook Build
51-
run: npm run build-storybook
52-
env:
53-
PATH_PREFIX: ${{ github.event.pull_request.number }}/
54-
5550
- name: Upload to GCS
5651
run: gsutil -m rsync -R public gs://staging.nodejs.dev/${{ github.event.pull_request.number }}/
5752

‎.storybook/main.js‎

Lines changed: 0 additions & 102 deletions
This file was deleted.

‎.storybook/preview.js‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎CONTRIBUTING.md‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,6 @@ In the case of an objection being raised in a pull request by another collaborat
9494
* Pull Request must remain open for 72 hours without any objections
9595
* Once the requirements are met and approved, the pull request can be merged and a member of @nodejs/community-committee will add the new member to the [@nodejs/nodejs-dev team](https://github.com/orgs/nodejs/teams/nodejs-dev)
9696

97-
## 📕 Storybook
98-
99-
This project uses [Storybook][], a tool which provides a sandbox environment for developing UI components. To generate the Storybook locally:
100-
101-
* Run `npm run storybook`
102-
* Navigate to `localhost:6006`
103-
104-
The production Storybook can be viewed at <https://nodejs.dev/storybook>
10597

10698
## 🐛 Debugging Failing Checks
10799

@@ -135,7 +127,6 @@ By making a contribution to this project, I certify that:
135127
including my sign-off) is maintained indefinitely and may be redistributed consistent
136128
with this project or the open source license(s) involved.
137129

138-
[Storybook]: https://storybook.js.org/
139130
[`squash`]: https://help.github.com/en/articles/about-pull-request-merges#squash-and-merge-your-pull-request-commits
140131
[conventional commits]: https://www.conventionalcommits.org/
141132
[nodejs.dev repo]: https://github.com/nodejs/nodejs.dev

‎cloudbuild-deploy.yaml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ steps:
1919
- name: 'node:16'
2020
entrypoint: npm
2121
args: ['run', 'build']
22-
- name: 'node:16'
23-
entrypoint: npm
24-
args: ['run', 'build-storybook']
2522
- name: 'gcr.io/$PROJECT_ID/firebase'
2623
args: ['deploy', '--project', '$PROJECT_ID', '--only', 'hosting']
2724
timeout: 900s

‎content/learn/node-control-flow.en.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function middleware(someInput, callback) {
5757

5858
function initiate() {
5959
const someInput = 'hello this is a function ';
60-
middleware(function (result) {
60+
middleware(someInput, function (result) {
6161
console.log(result);
6262
// requires callback to `return` result
6363
});
@@ -209,7 +209,7 @@ function final(result) {
209209
\n${result.failed.join('\n')}\n`);
210210
}
211211

212-
items.forEach(function (recipient) {
212+
recipients.forEach(function (recipient) {
213213
dispatch(recipient, function (err) {
214214
if (!err) {
215215
success += 1;

‎content/learn/node-run-cli.en.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,16 @@ chmod u+x app.js
3636

3737
While running the command, make sure you are in the same directory which contains the `app.js` file.
3838

39+
## Pass string as argument to `node` instead of file path
40+
41+
To execute a string as argument you can use `-e`, `--eval "script"`. Evaluate the following argument as JavaScript. The modules which are predefined in the REPL can also be used in script.
42+
43+
On Windows, using cmd.exe a single quote will not work correctly because it only recognizes double `"` for quoting. In Powershell or Git bash, both `'` and `"` are usable.
44+
45+
```bash
46+
node "console.log(123)"
47+
```
48+
3949
## Restart the application automatically
4050

4151
The `node` command has to be re-executed in bash whenever there is a change in the application. To restart the application automatically, use the `nodemon` module.

0 commit comments

Comments
 (0)