Relevant diff for the trap handler stuff:

diff --git a/BUILD.gn b/BUILD.gn
index cdbef4ad38..bca193c467 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -4042,9 +4054,10 @@ v8_header_set("v8_internal_headers") {
       sources += [ "src/execution/arm64/pointer-authentication-arm64.h" ]
     }
     if (v8_enable_webassembly) {
-      # Trap handling is enabled on arm64 Mac and in simulators on x64 on Linux
-      # and Mac.
-      if ((current_cpu == "arm64" && (is_mac || is_ios)) ||
+      # Trap handling is enabled on arm64 Mac and Linux and in simulators on
+      # x64 on Linux and Mac.
+      if ((current_cpu == "arm64" &&
+           (is_linux || is_chromeos || is_mac || is_ios)) ||
           (current_cpu == "x64" && (is_linux || is_chromeos || is_mac))) {
         sources += [ "src/trap-handler/handler-inside-posix.h" ]
       }
@@ -5273,9 +5286,9 @@ v8_source_set("v8_base_without_compiler") {
       "src/regexp/arm64/regexp-macro-assembler-arm64.cc",
     ]
     if (v8_enable_webassembly) {
-      # Trap handling is enabled on arm64 Mac and in simulators on x64 on Linux,
-      # Mac, and Windows.
-      if ((current_cpu == "arm64" && is_apple) ||
+      # Trap handling is enabled on arm64 Mac and Linux and in simulators on
+      # x64 on Linux, Mac, and Windows.
+      if ((current_cpu == "arm64" && (is_linux || is_chromeos || is_apple)) ||
           (current_cpu == "x64" && (is_linux || is_chromeos || is_mac))) {
         sources += [
           "src/trap-handler/handler-inside-posix.cc",

Uh oh!

Review state of canary in CI #249

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions