feat: Support for Visual Studio 2026 (18.x) to enable node-gyp to work with the latest Visual Studio preview and release versions.#3240
Merged
lukekarrys merged 1 commit intonodejs:mainfrom Nov 12, 2025
Conversation
feat: Add support for Visual Studio 2026 (18.x) - Add versionMajor 18 mapping to versionYear 2026 - Update toolset to v145 for VS2026 (confirmed from MS docs) - Support both Insiders (18\Insiders) and Release (2026\Community) installation paths - Add comprehensive test coverage for both VS2026 variants - Maintain backward compatibility with all existing VS versions This enables node-gyp to work with Visual Studio 2026 Preview/Insiders and future 18.x releases.
Closed
xxairsky
changed the title
xxairsky
changed the title
legendecas
reviewed
Nov 12, 2025
| } else if (versionYear === 2022) { | ||
| return 'v143' | ||
| } else if (versionYear === 2026) { | ||
| return 'v145' |
Member
There was a problem hiding this comment.
It seems like this version has not been updated in the doc yet: https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros
Contributor
Author
There was a problem hiding this comment.
It seems like this version has not been updated in the doc yet: https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros
Clearly, Microsoft's development team is far behind in terms of documentation update speed.
However, I can assure you that VS2026 uses version 145 and has passed rigorous unit and compilation tests.
My personal product has been successfully compiled and released using this PR. ;)
legendecas
approved these changes
Nov 12, 2025
legendecas
changed the title
lukekarrys
approved these changes
Nov 12, 2025
This was referenced Nov 12, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
Add support for Visual Studio 2026 (18.x) to enable node-gyp to work with the latest Visual Studio preview and release versions.
Changes made:
getVersionInfo()functionC:\Program Files\Microsoft Visual Studio\18\InsidersC:\Program Files\Microsoft Visual Studio\2026\CommunityTechnical Details:
lib/find-visualstudio.jswith new version mappingsVS_2026_Insiders_workload.txtandVS_2026_Community_workload.txtThis change enables developers using Visual Studio 2026 to compile native Node.js addons without manual configuration.