lib: accept extra spaces in the collaborators list #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 93.69% 93.71% +0.01%
==========================================
Files 18 18
Lines 666 668 +2
==========================================
+ Hits 624 626 +2
Misses 42 42
Continue to review full report at Codecov.
|
joyeecheung
approved these changes
Feb 16, 2018
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Thanks for catching that!
priyank-p
approved these changes
Feb 16, 2018
Contributor
priyank-p
left a comment
priyank-p
left a comment
There was a problem hiding this comment.
We need to add a quick tests for it in collaborators.test.js
tniessen
approved these changes
Feb 16, 2018
Contributor
|
Merged after adding a quick little test, thanks @mmarchini. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get-metadatawill skip collaborators from the list without warning if there are extra spaces. For example:Ref: nodejs/node#18822