fix: ignore fully skipped startup failures - #1170
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
+ Coverage 57.81% 57.86% +0.04%
==========================================
Files 53 53
Lines 10397 10409 +12
==========================================
+ Hits 6011 6023 +12
Misses 4386 4386 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions can report a check suite as
STARTUP_FAILUREeven when every check run in that suite was skipped. This causedcheckGitHubCI()to mark the PR as unlandable without reporting a specific failed job or reason code.Ignore this suite-level result when every check run was fetched and every run completed with
SKIPPED. Other startup failures continue to block landing and now fall back to a suite-level diagnostic when no failed check run is available.Query the check-run
totalCountto ensure truncated results are not mistaken for a fully skipped suite.Observed in nodejs/node#65538 (comment)
https://github.com/nodejs/node/actions/runs/32985142178/attempts/1
https://github.com/nodejs/node/actions/runs/32984879569/attempts/1