src: rename N-API with Node-API on comments#953
Closed
NickNaso wants to merge 2 commits into
Closed
Conversation
legendecas
approved these changes
Mar 26, 2021
legendecas
left a comment
legendecas
left a comment
Member
There was a problem hiding this comment.
LGTM. I assume most of the unrelated changes are subject to linter complaints?
Member
Author
Yes. |
gabrielschulhof
left a comment
gabrielschulhof
left a comment
Contributor
There was a problem hiding this comment.
This PR does more than rename N-API to Node-API. There are also a bunch of whitespace changes. Would it be OK to just stick to the renaming? Otherwise it may create some churn.
Contributor
|
Oh. Didn't see the convo. NM. |
gabrielschulhof
approved these changes
Mar 28, 2021
Contributor
Contributor
|
Landed in 6280236. |
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
Also fixed lint errors. Fixes: nodejs#952 PR-URL: nodejs#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
Also fixed lint errors. Fixes: nodejs#952 PR-URL: nodejs#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Also fixed lint errors. Fixes: nodejs/node-addon-api#952 PR-URL: nodejs/node-addon-api#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Also fixed lint errors. Fixes: nodejs/node-addon-api#952 PR-URL: nodejs/node-addon-api#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Also fixed lint errors. Fixes: nodejs/node-addon-api#952 PR-URL: nodejs/node-addon-api#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Also fixed lint errors. Fixes: nodejs/node-addon-api#952 PR-URL: nodejs/node-addon-api#953 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #952
In this PR I renamed N-API to Node-API in all the comments in the source code.