Skip to content

[doc] Fixed links to array documentation#613

Merged
mhdawson merged 2 commits into
nodejs:masterfrom
NickNaso:fix-link-array-in-object
Dec 5, 2019
Merged

[doc] Fixed links to array documentation#613
mhdawson merged 2 commits into
nodejs:masterfrom
NickNaso:fix-link-array-in-object

Conversation

@NickNaso

Copy link
Copy Markdown
Member

Fixed all the links to Napi::Array documentation.
Fixes issue #612

@zander

zander commented Nov 30, 2019

Copy link
Copy Markdown

While you are in this file anyway.
The line you changed says "and extends". Which IMOHO is a bit confusing.

Maybe you can change that to say "is extended by".

Napi::Value which is extended by Napi::Array

@zander

zander commented Nov 30, 2019

Copy link
Copy Markdown

The dead link (to array.md) may be present in other docs pages as well.

I noticed it also in https://github.com/nodejs/node-addon-api/blob/master/doc/value.md

@NickNaso NickNaso added the doc label Nov 30, 2019

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit e71d0ea into nodejs:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants