Skip to content

Added cpp highlight for string.md#329

Closed
yjaeseok wants to merge 1 commit into
nodejs:masterfrom
yjaeseok:md
Closed

Added cpp highlight for string.md#329
yjaeseok wants to merge 1 commit into
nodejs:masterfrom
yjaeseok:md

Conversation

@yjaeseok

@yjaeseok yjaeseok commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

There is no cpp highlight for some function in string.md file.

There is no cpp highlight for some function in string.md file.

@NickNaso NickNaso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Sep 6, 2018
There is no cpp highlight for some function in string.md file.

PR-URL: #329
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
@mhdawson

mhdawson commented Sep 6, 2018

Copy link
Copy Markdown
Member

Landed as 7cdd787

@mhdawson mhdawson closed this Sep 6, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
There is no cpp highlight for some function in string.md file.

PR-URL: nodejs/node-addon-api#329
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
There is no cpp highlight for some function in string.md file.

PR-URL: nodejs/node-addon-api#329
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
There is no cpp highlight for some function in string.md file.

PR-URL: nodejs/node-addon-api#329
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
There is no cpp highlight for some function in string.md file.

PR-URL: nodejs/node-addon-api#329
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants