Plumb node api version through to build#1399
Closed
gabrielschulhof wants to merge 3 commits into
Closed
Conversation
gabrielschulhof
requested review from
KevinEady,
legendecas,
mhdawson and
vmoroz
legendecas
approved these changes
Nov 3, 2023
Contributor
Author
Contributor
Author
|
Landed in c52e764. |
gabrielschulhof
added a commit
that referenced
this pull request
Nov 6, 2023
…callback PR-URL: #1399 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttachDataas a template parameter.NAPI_VERSIONthrough to the build.These are preparatory steps for building with
NAPI_EXPERIMENTALonce more. Currently doing so bumps against the newenv->CheckGCAccess()in core.