Skip to content

test: Add tests for cb scope#1262

Closed
JckXia wants to merge 3 commits into
nodejs:mainfrom
JckXia:add-tests-for-cb-scope
Closed

test: Add tests for cb scope#1262
JckXia wants to merge 3 commits into
nodejs:mainfrom
JckXia:add-tests-for-cb-scope

Conversation

@JckXia

@JckXia JckXia commented Jan 4, 2023

Copy link
Copy Markdown
Member

Adding test coverage for CallbackScopes, closes #1044

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Jan 13, 2023
PR-URL: #1262
Reviewed-By: Michael Dawson <midawson@redhat.com
@mhdawson

Copy link
Copy Markdown
Member

Landed as 0213134

@mhdawson mhdawson closed this Jan 13, 2023
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#1262
Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] Callback scope unit test coverage

2 participants