Create a doc for migration#118
Conversation
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I would add a paragraph explaining how different is ObjectWrap between NAN and node-addon-api. In NAN, JavaScript methods are defined via static C++ methods. In node-addon-api, they are defined as C++ instance methods. It is a significant difference.
|
@sampsongao are you going to add the paragraph requested by @mcollina ? I'm waiting on that to do a thorough review. |
|
Will do that next week. Currently busy with some other stuff. |
sampsongao
force-pushed
the
doc_for_migration
branch
from
1c5aa3d to
a2a7962
Compare
|
@sampsongao ping ? |
|
@sampsongao, probably also needs to be sync'd with some of the other doc work being done. |
|
@sampsongao are you still going to be able to update ? |
|
I don't have anything to update on my side. |
|
@mcollina if your comments have been addressed can you review/approve? |
PR-URL: #118 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matteo Collina <hello@matteocollina.com>
|
Landed as 7f3ca03 |
PR-URL: nodejs/node-addon-api#118 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs/node-addon-api#118 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs/node-addon-api#118 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs/node-addon-api#118 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matteo Collina <hello@matteocollina.com>
3 participants
Feel free to comment about things that are not covered here.