test: refactor test-crypto-certificate#9911
Closed
JoshuaMays wants to merge 3 commits intonodejs:masterfrom
Closed
test: refactor test-crypto-certificate#9911JoshuaMays wants to merge 3 commits intonodejs:masterfrom
JoshuaMays wants to merge 3 commits intonodejs:masterfrom
Conversation
Replace assert.equal with assert.strictEqual
imyller
added
the
code-and-learn
princejwesley
approved these changes
Dec 1, 2016
Contributor
princejwesley
left a comment
princejwesley
left a comment
There was a problem hiding this comment.
commit msg can be test: refactor test-crypto-certificate 😄
JoshuaMays
changed the title
added 2 commits
December 1, 2016 11:39
Replace assert.equal with assert.strictEqual
…ode into fix-test-crypto-certificate
cjihrig
approved these changes
Dec 4, 2016
addaleax
approved these changes
Dec 5, 2016
Member
|
Single build failure on CI is unrelated. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in d927668. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9911 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Replace assert.equal with assert.strictEqual