test: update test-debugger-client.js to use strictEqual#9857
Closed
bencripps wants to merge 1 commit intonodejs:masterfrom
Closed
test: update test-debugger-client.js to use strictEqual#9857bencripps wants to merge 1 commit intonodejs:masterfrom
bencripps wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
LGTM if CI is ✅ |
Member
cjihrig
approved these changes
Dec 1, 2016
targos
approved these changes
Dec 1, 2016
lpinca
reviewed
Dec 1, 2016
Member
There was a problem hiding this comment.
Nit: can you please swap the arguments here and throughout the rest of the file where it makes sense?
assert.strictEqual(resCount, 1);This because the first argument is the actual and the second is the expected.
Feel free to ignore this :)
Contributor
Author
There was a problem hiding this comment.
Agreed, I've fixed up my commit to include these changes.
lpinca
approved these changes
Dec 1, 2016
bencripps
force-pushed
the
feature/update-test-debugger-client
branch
from
a7e0068 to
f6036b4
Compare
Member
Member
|
CI failure on SmartOS is unrelated. Landing! |
Member
|
Landed in 4658d0c. Thanks, welcome, and congrats on your first Node.js commit, @bencripps! |
Trott
pushed a commit
that referenced
this pull request
Dec 3, 2016
PR-URL: #9857 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
PR-URL: #9857 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9857 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9857 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9857 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Only test files have been modified.
Description of change
Updated
test-debugger-client.jsto usestrictEqualinstead ofequalfor higher fidelity testing.