meta: clarify collaborators & ctc members relationships#7996
meta: clarify collaborators & ctc members relationships#7996yorkie wants to merge 1 commit intonodejs:masterfrom
Conversation
yorkie
added
the
meta
|
LGTM! Thank you! |
README.md
Outdated
There was a problem hiding this comment.
Something is wrong on this line. Perhaps, Collaborators (including CTC members)? Also, why is would needed here? Also not sure about Therefore.
|
Fixed nits by @ChALkeR and still leave the word |
README.md
Outdated
There was a problem hiding this comment.
There's a comma splice in there and a personal pronoun that should be removed. I'd simplify the whole sentence to just this:
Note that all CTC members are also Collaboartors.
There was a problem hiding this comment.
Actually, I'd suggest removing all the added text and just changing the original sentence from starting with Collaborators & CTC members follow... to Collaborators (which includes CTC members) follow...
|
Fixed again @Trott |
README.md
Outdated
There was a problem hiding this comment.
& CTC members is probably not needed here.
|
Fixed @ChALkeR :-) |
|
LGTM |
|
Rebased commits to d743a8b, I will land it after 48 hours without running CI because this only patches README which is not covered by any tests, if CI is still required to run, tell me please :-) BTW, ping @ChALkeR is this pr looks good to you? |
|
@yorkie Yes, it does LGTM. Note that I'm not a native English speaker, though, so my LGTM is less valuable here.
It's not yet, but soon will be =). Not in under 48 hours ofc. |
So may I land it today? |
|
LGTM |
|
@yorkie Yes =). |
|
LGTM |
inspired by this conversation nodejs#7183 (comment) PR-URL: nodejs#7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed at accaa34 :-) |
inspired by this conversation #7183 (comment) PR-URL: #7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
inspired by this conversation #7183 (comment) PR-URL: #7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
inspired by this conversation #7183 (comment) PR-URL: #7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
inspired by this conversation #7183 (comment) PR-URL: #7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
inspired by this conversation #7183 (comment) PR-URL: #7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
inspired by this conversation #7183 (comment) PR-URL: #7996 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 participants
Checklist
Affected core subsystem(s)
meta
Description of change
Clarifying collaborators & ctc members relationships inspired by this conversation
#7183 (comment)
This patches only the README, so I removed test relevant checks :-)
R= @jasnell