Skip to content

installer: don't install node_internals.h #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bnoordhuis merged 0 commits into from
May 22, 2016
Merged

installer: don't install node_internals.h #6913

bnoordhuis merged 0 commits into from
May 22, 2016

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented May 21, 2016

As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

(And that's why we have code reviews.)

No CI, it doesn't exercise the installer.

@bnoordhuis bnoordhuis added install Issues and PRs related to the installers. lts-watch-v4.x labels May 21, 2016
@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 21, 2016
@jasnell
Copy link
Member

jasnell commented May 21, 2016

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented May 21, 2016

LGTM

@eljefedelrodeodeljefe
Copy link
Contributor

eljefedelrodeodeljefe commented May 21, 2016

LGTM

@jbergstroem
Copy link
Member

jbergstroem commented May 22, 2016

LGTM

@bnoordhuis bnoordhuis closed this May 22, 2016
@bnoordhuis bnoordhuis force-pushed the installer-omit-internals branch from 5f79cd2 to b0e8a42 Compare May 22, 2016 06:56
@bnoordhuis bnoordhuis deleted the installer-omit-internals branch May 22, 2016 06:56
@bnoordhuis bnoordhuis merged commit b0e8a42 into nodejs:master May 22, 2016
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@bnoordhuis @Fishrock123
installer: don't install node_internals.h
efdc1d3 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@bnoordhuis @rvagg
installer: don't install node_internals.h
6f0d8b3 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
@bnoordhuis bnoordhuis mentioned this pull request Jun 29, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@bnoordhuis
installer: don't install node_internals.h
3830bc7 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@bnoordhuis
installer: don't install node_internals.h
93d27d7 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis @MylesBorins
installer: don't install node_internals.h
76ceea3 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
installer: don't install node_internals.h
33274cf 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
installer: don't install node_internals.h
b2a8eab 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
installer: don't install node_internals.h
373ffc5 
As the name suggests, it's for internal use only, so don't install it.

Including it in an add-on doesn't work because the file depends on other
header files that are not installed.

Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").

PR-URL: #6913
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. install Issues and PRs related to the installers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bnoordhuis @jasnell @cjihrig @eljefedelrodeodeljefe @jbergstroem @mscdex @MylesBorins